Skip to content

extra: Put the nail in the coffin, delete libextra #12896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2014
Merged

extra: Put the nail in the coffin, delete libextra #12896

merged 1 commit into from
Mar 15, 2014

Conversation

alexcrichton
Copy link
Member

This commit shreds all remnants of libextra from the compiler and standard
distribution. Two modules, c_vec/tempfile, were moved into libstd after some
cleanup, and the other modules were moved to separate crates as seen fit.

Closes #8784
Closes #12413
Closes #12576

@flaper87
Copy link
Contributor

👏

@sfackler
Copy link
Member

The rust-lang.org homepage will need to be updated for this.

@alexcrichton
extra: Put the nail in the coffin, delete libextra
58e4ab2 
This commit shreds all remnants of libextra from the compiler and standard
distribution. Two modules, c_vec/tempfile, were moved into libstd after some
cleanup, and the other modules were moved to separate crates as seen fit.

Closes rust-lang#8784
Closes rust-lang#12413
Closes rust-lang#12576
@brson
Copy link
Contributor

brson commented Mar 15, 2014

Perhaps we can find different homes for these modules later? I hate to think they got promoted to std just because they were the last modules standing.

@alexcrichton
Copy link
Member Author

I think that c_vec should end up wherever c_str goes (they're pretty much the same thing), and tempfile is arguably a core-ish functionality, but it's sad to lose the true random directory names.

@huonw
Copy link
Member

huonw commented Mar 15, 2014

sad to lose the true random directory names

We could have the core rand functionality as super-secret inside libstd, and reexport it in librand.

bors added a commit that referenced this pull request Mar 15, 2014
@bors
auto merge of #12896 : alexcrichton/rust/goodbye-extra, r=brson
fc7a112 
This commit shreds all remnants of libextra from the compiler and standard
distribution. Two modules, c_vec/tempfile, were moved into libstd after some
cleanup, and the other modules were moved to separate crates as seen fit.

Closes #8784
Closes #12413
Closes #12576
@bors bors closed this Mar 15, 2014
@bors bors merged commit 58e4ab2 into rust-lang:master Mar 15, 2014
@derekchiang
Copy link
Contributor

Just wanted to point out that there are dead links to extra on the homepage and also the "other docs" page.

@alexcrichton alexcrichton deleted the goodbye-extra branch March 15, 2014 22:40
@alexcrichton
Copy link
Member Author

See rust-lang/prev.rust-lang.org#22 for removal of the links.

@ghost ghost mentioned this pull request Mar 16, 2014
Merged
Kroisse added a commit to Kroisse/rust-mustache that referenced this pull request Mar 17, 2014
@Kroisse
Follow the latest changes
f23560f 
See also:
- rust-lang/rust#12791
- rust-lang/rust#12756
- rust-lang/rust#12896
@Kroisse Kroisse mentioned this pull request Mar 17, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@alexcrichton @flaper87 @sfackler @brson @huonw @derekchiang @bors